From ac184af84e0d196e7bd87b510a99248b6d0f6948 Mon Sep 17 00:00:00 2001
From: Vincent Vanwaelscappel <vincent@cubedesigners.com>
Date: Mon, 27 May 2024 13:57:40 +0200
Subject: [PATCH] wip #6915 @2

---
 .../Controllers/CubistSelect2Controller.php   |  7 ------
 .../Magic/Models/CubistMagicAbstractModel.php |  2 +-
 .../views/fields/select2_from_array.blade.php | 25 ++++++++++---------
 src/resources/views/when.blade.php            |  3 +++
 4 files changed, 17 insertions(+), 20 deletions(-)

diff --git a/src/app/Http/Controllers/CubistSelect2Controller.php b/src/app/Http/Controllers/CubistSelect2Controller.php
index 389e092..60bbb2e 100644
--- a/src/app/Http/Controllers/CubistSelect2Controller.php
+++ b/src/app/Http/Controllers/CubistSelect2Controller.php
@@ -12,13 +12,6 @@ class CubistSelect2Controller
 {
     public function search($hash)
     {
-        if (!Auth::check()) {
-            return response(null)->setStatusCode('401');
-        }
-        if (!can('edition')) {
-            return response(null)->setStatusCode('403');
-        }
-
         $perPage = 10;
         $data = Cache::get('select2_' . $hash) ?? [];
         $term = request()->get('q', null);
diff --git a/src/app/Magic/Models/CubistMagicAbstractModel.php b/src/app/Magic/Models/CubistMagicAbstractModel.php
index 08e9c48..bf5c251 100644
--- a/src/app/Magic/Models/CubistMagicAbstractModel.php
+++ b/src/app/Magic/Models/CubistMagicAbstractModel.php
@@ -716,7 +716,7 @@ class CubistMagicAbstractModel extends Model implements HasMedia
                 $res->set($key, $v);
                 continue;
             }
-            $res->set($key, Json::decodeRecursive($v, Json::TYPE_ARRAY));
+            $res->setRaw($key, Json::decodeRecursive($v, Json::TYPE_ARRAY));
         }
         return $res;
     }
diff --git a/src/resources/views/fields/select2_from_array.blade.php b/src/resources/views/fields/select2_from_array.blade.php
index 55044bc..d878567 100644
--- a/src/resources/views/fields/select2_from_array.blade.php
+++ b/src/resources/views/fields/select2_from_array.blade.php
@@ -16,6 +16,7 @@
             if(is_scalar($o)){
                 return $o==$key;
             }
+            $o=\Cubist\Util\ArrayUtil::asArray($o);
             return in_array($key,$o);
         }
     }
@@ -28,22 +29,22 @@ if($ajax){
 }
 @endphp
 
-        <!-- select2 from array -->
+    <!-- select2 from array -->
 @include('crud::fields.inc.wrapper_start')
 <label>{!! $field['label'] !!}</label>
 @if (isset($field['allows_multiple']) && $field['allows_multiple']==true)
     <input type="hidden" name="{{ $field['name'] }}" value=""/>
 @endif
 <select
-        name="{{ $field['name'] }}@if (isset($field['allows_multiple']) && $field['allows_multiple']==true)[]@endif"
-        style="width: 100%"
-        @include('crud::fields.inc.attributes', ['default_class' =>  'form-control select2_from_array'])
-        @if (isset($field['allows_multiple']) && $field['allows_multiple']==true)multiple @endif
-        @if($ajax) data-ajax="{{$field['ajax']}}" @endif
-        @if($allows_html) data-allow-html="1" @endif
-        data-options="{{ json_encode($field['options']) }}"
-        @if(isset($field['free']) && $field['free']) data-free="1" @endif
-        data-value="{{is_scalar($o)?$o:json_encode($o)}}"
+    name="{{ $field['name'] }}@if (isset($field['allows_multiple']) && $field['allows_multiple']==true)[]@endif"
+    style="width: 100%"
+    @include('crud::fields.inc.attributes', ['default_class' =>  'form-control select2_from_array'])
+    @if (isset($field['allows_multiple']) && $field['allows_multiple']==true)multiple @endif
+    @if($ajax) data-ajax="{{$field['ajax']}}" @endif
+    @if($allows_html) data-allow-html="1" @endif
+    data-options="{{ json_encode($field['options']) }}"
+    @if(isset($field['free']) && $field['free']) data-free="1" @endif
+    data-value="{{is_scalar($o)?$o:json_encode($o)}}"
 >
     @if (isset($field['allows_null']) && $field['allows_null']==true)
         @if($is_null)
@@ -98,8 +99,8 @@ if($ajax){
         <link href="{{ asset('packages/select2/dist/css/select2.min.css') }}" rel="stylesheet"
               type="text/css"/>
         <link
-                href="{{ asset('packages/select2-bootstrap-theme/dist/select2-bootstrap.min.css') }}"
-                rel="stylesheet" type="text/css"/>
+            href="{{ asset('packages/select2-bootstrap-theme/dist/select2-bootstrap.min.css') }}"
+            rel="stylesheet" type="text/css"/>
     @endpush
 
     {{-- FIELD JS - will be loaded in the after_scripts section --}}
diff --git a/src/resources/views/when.blade.php b/src/resources/views/when.blade.php
index 99d17ec..a4d2449 100644
--- a/src/resources/views/when.blade.php
+++ b/src/resources/views/when.blade.php
@@ -85,6 +85,9 @@
                     if (condition.id === undefined) {
                         condition.id = '';
                     }
+                    if (condition.id === '_empty_' || condition.operator === 'empty') {
+                        return val.toString().length === 0;
+                    }
                     if (condition.id === '_not_empty_' || condition.operator === 'not_empty') {
                         return val.toString().length > 0;
                     }
-- 
2.39.5