From 6bdc294a890f72f507ab71f515604b401cce71d6 Mon Sep 17 00:00:00 2001 From: Vincent Vanwaelscappel Date: Fri, 6 Sep 2019 11:46:28 +0200 Subject: [PATCH] wip #2922 @0.25 --- app/Http/Middleware/Menu.php | 6 +++++- app/Templates/Catalog.php | 2 ++ app/Templates/News.php | 1 + app/Templates/Solution.php | 1 + resources/js/menu.js | 2 -- 5 files changed, 9 insertions(+), 3 deletions(-) diff --git a/app/Http/Middleware/Menu.php b/app/Http/Middleware/Menu.php index 93ad100..b86e902 100644 --- a/app/Http/Middleware/Menu.php +++ b/app/Http/Middleware/Menu.php @@ -19,9 +19,13 @@ class Menu public function makePMIMenu($menu, $item) { foreach ($item->getChildren() as $child) { + if (!$child->isMenuDesktop()) { + continue; + } $parent = $menu->add($child->getTitle(), $child->getHref()); + // Handle items with submenus - if ($child->hasChildren()) { + if ($child->isMenuDesktopChildren() && $child->hasChildren()) { // Create an empty sub-element that will serve as a wrapper for the submenu(s) if ($child->getType() == 'mega') { diff --git a/app/Templates/Catalog.php b/app/Templates/Catalog.php index 66b34ff..044e237 100644 --- a/app/Templates/Catalog.php +++ b/app/Templates/Catalog.php @@ -53,6 +53,7 @@ class Catalog extends TemplateAbstract $category->setHref($productType->getSlugOrTitleAttribute()); $category->setId('product_type/' . $productType->id); $category->setController(['controller' => 'ProductController', 'action' => 'productList', 'params' => ['id' => $productType->id]]); + $category->showInAllMenus(); $count = 0; foreach ($products as $product) { @@ -68,6 +69,7 @@ class Catalog extends TemplateAbstract $detail->setHref($product->getSlugOrTitleAttribute()); $detail->setId('product/' . $product->id); $detail->setController(['controller' => 'ProductController', 'action' => 'productDetails', 'params' => ['id' => $product->id]]); + $detail->hideInAllMenus(); $category->addChild($detail); $count++; } diff --git a/app/Templates/News.php b/app/Templates/News.php index 132ba07..9cd43b7 100644 --- a/app/Templates/News.php +++ b/app/Templates/News.php @@ -36,6 +36,7 @@ class News extends Base $item->setHref($newsItem->slug); // Todo: consider having a configurable / translatable prefix for news URLs $item->setId('news/' . $newsItem->id); $item->setController(['controller' => 'NewsController', 'action' => 'view', 'params' => ['id' => $newsItem->id]]); + $item->hideInAllMenus(); $menu->addChild($item); } diff --git a/app/Templates/Solution.php b/app/Templates/Solution.php index 7ca9180..d565b97 100644 --- a/app/Templates/Solution.php +++ b/app/Templates/Solution.php @@ -51,6 +51,7 @@ class Solution extends Base $item->setHref($application->getSlugOrTitleAttribute()); $item->setId('application/' . $application->id); $item->setController(['controller' => 'ApplicationController', 'action' => 'view', 'params' => ['id' => $application->id]]); + $item->hideInAllMenus(); $menu->addChild($item); } diff --git a/resources/js/menu.js b/resources/js/menu.js index 90595f9..c22d929 100644 --- a/resources/js/menu.js +++ b/resources/js/menu.js @@ -21,7 +21,6 @@ document.addEventListener( event.stopPropagation(); if (null === document.querySelector('.mm--close')) { - console.log(':)'); nav.innerHTML = '' + nav.innerHTML; document.querySelector('.mm--close').addEventListener('click', (event) => { @@ -38,7 +37,6 @@ document.addEventListener( ); function checkOpenSubmenu() { - console.log(document.querySelector('#mobile-nav.mm--open.mm--main')); if (null === document.querySelector('#mobile-nav.mm--open.mm--main')) { document.body.classList.add('mm--subopen'); } else { -- 2.39.5