From 0b527ec4c9400398c2143b4b0506a322c123314e Mon Sep 17 00:00:00 2001
From: Vincent Vanwaelscappel <vincent@cubedesigners.com>
Date: Fri, 26 May 2023 09:37:10 +0200
Subject: [PATCH] wip #5877 @@0.5

---
 app/Fluidbook/Stats.php                       | 22 +++++++------------
 .../FluidbookPublication/StatsOperation.php   |  2 +-
 2 files changed, 9 insertions(+), 15 deletions(-)

diff --git a/app/Fluidbook/Stats.php b/app/Fluidbook/Stats.php
index c712191e1..b8ca0832a 100644
--- a/app/Fluidbook/Stats.php
+++ b/app/Fluidbook/Stats.php
@@ -23,6 +23,13 @@ class Stats extends Reporting
     // - https://redmine.cubedesigners.com/issues/5473
     const SHOW_VISITORS_CUTOFF = 20687;
 
+    const TOKENS=[
+        'stats3.fluidbook.com' => '9df722a0bd30878ddc4d737352427502',
+        'stats4.fluidbook.com' => '3ffdbe052ae625f065573df9fa9515df',
+        'stats5.fluidbook.com' => '85e9cc307b6e5083249949e9472a80b8',
+        'stats6.fluidbook.com' => '16f4c1d77cdc4792b807718388db96a0',
+    ];
+
 
     /**
      * @var int
@@ -80,18 +87,6 @@ class Stats extends Reporting
         return $this->getMatomoToken(static::getMatomoServer($this->fluidbook->id));
     }
 
-    protected function getMatomoTokens()
-    {
-        // Each stats server has a different instance of Matamo, so we need to provide different API tokens for each
-        // Normally this information would be stored in the .env but there's no good way to do that with an array, so
-        // it is simpler to keep it here. These are also stored in the shared Bitwarden entry for Matomo.
-        return [
-            'stats3.fluidbook.com' => '9df722a0bd30878ddc4d737352427502',
-            'stats4.fluidbook.com' => '3ffdbe052ae625f065573df9fa9515df',
-            'stats5.fluidbook.com' => '85e9cc307b6e5083249949e9472a80b8',
-            'stats6.fluidbook.com' => '16f4c1d77cdc4792b807718388db96a0',
-        ];
-    }
 
     protected static function getPeriods()
     {
@@ -138,8 +133,7 @@ class Stats extends Reporting
 
     protected function getMatomoToken($server): bool|string
     {
-        $tokens = $this->getMatomoTokens();
-        return $tokens[$server] ?? false;
+        return self::TOKENS[$server] ?? false;
     }
 
     protected function setDatesAndPeriod($period_override = null)
diff --git a/app/Http/Controllers/Admin/Operations/FluidbookPublication/StatsOperation.php b/app/Http/Controllers/Admin/Operations/FluidbookPublication/StatsOperation.php
index 730f5f345..923f91989 100644
--- a/app/Http/Controllers/Admin/Operations/FluidbookPublication/StatsOperation.php
+++ b/app/Http/Controllers/Admin/Operations/FluidbookPublication/StatsOperation.php
@@ -85,7 +85,7 @@ trait StatsOperation
             return response(null)->setStatusCode('403');
         }
 
-        $matomo_tokens = json_encode($this->getMatomoTokens());
+        $matomo_tokens = json_encode(Stats::TOKENS);
         return view('fluidbook_stats.API', compact('matomo_tokens', 'id'));
     }
 
-- 
2.39.5