From: Vincent Vanwaelscappel <vincent@cubedesigners.com>
Date: Tue, 24 Sep 2019 17:01:51 +0000 (+0200)
Subject: fix #3066 @0.5
X-Git-Url: http://git.cubedesigners.com/?a=commitdiff_plain;h=c53a0c30ad99a85898ff796faf60e62ad9c38aff;p=cubist_cms-back.git

fix #3066 @0.5
---

diff --git a/src/app/Magic/Menu/Menu.php b/src/app/Magic/Menu/Menu.php
index 73ddd9b..d3cacad 100644
--- a/src/app/Magic/Menu/Menu.php
+++ b/src/app/Magic/Menu/Menu.php
@@ -219,19 +219,30 @@ class Menu extends BaseMenu
             if ($item->isActive) {
                 $active = ' active';
             }
-            $res .= '<div class="breadcrumbs-item' . $active . '" itemprop="itemListElement" itemscope itemtype="http://schema.org/ListItem">';
-            $res .= '<a itemprop="item"';
+            $hasurl = !!$item->url();
 
-            if ($item->url()) {
-                $res .= ' href="' . $item->url() . '"';
+            $res .= '<div class="breadcrumbs-item' . $active . '"';
+            if ($hasurl) {
+                $res .= ' itemprop="itemListElement" itemscope itemtype="http://schema.org/ListItem"';
             }
             $res .= '>';
-            $res .= '<span itemprop="item">' . $item->title . "</span>";
-            $res .= '<meta itemprop="position" content="' . $position . '" />';
+            $res .= '<a';
+
+            if ($hasurl) {
+                $res .= ' itemprop="item" href="' . $item->url() . '"';
+            }
+            $res .= '>';
+            $res .= '<span';
+            if ($hasurl) {
+                $res .= ' itemprop="name"';
+            }
+            $res .= '>' . $item->title . "</span>";
+            if ($hasurl) {
+                $res .= '<meta itemprop="position" content="' . $position . '" />';
+                $position++;
+            }
             $res .= '</a>';
             $res .= '</div>';
-
-            $position++;
         }
         $res .= '</div>';
         return $res;