From: Vincent Vanwaelscappel Date: Wed, 15 Oct 2025 16:40:50 +0000 (+0200) Subject: wait #7802 @2 X-Git-Url: http://git.cubedesigners.com/?a=commitdiff_plain;h=89e4394545bbe1c586a19d066c21fc826e8e6e35;p=fluidbook-toolbox.git wait #7802 @2 --- diff --git a/app/Fluidbook/Compiler/Compiler.php b/app/Fluidbook/Compiler/Compiler.php index e24f14529..9f9e2766d 100644 --- a/app/Fluidbook/Compiler/Compiler.php +++ b/app/Fluidbook/Compiler/Compiler.php @@ -1289,8 +1289,6 @@ class Compiler extends Base implements CompilerInterface, IVirtualDirectoryError protected function writeScorm() { - - if (!$this->fluidbookSettings->scorm_title) { $this->fluidbookSettings->scorm_title = $this->fluidbookSettings->title; } diff --git a/app/Fluidbook/Packager/Online.php b/app/Fluidbook/Packager/Online.php index c66a348ce..d87e45836 100644 --- a/app/Fluidbook/Packager/Online.php +++ b/app/Fluidbook/Packager/Online.php @@ -18,7 +18,7 @@ class Online extends Packager { parent::preparePackage(); - $this->book->getSettings()->set('scorm_enable', $this->scormVariant); + $this->book->getSettings()->set('scorm_enable', $this->variant === 'scorm'); $this->_ext = $this->book->getSettings()->get('htmlExtension'); $this->book->getSettings()->set('actualHtmlExtension', $this->_ext); diff --git a/app/Fluidbook/Packager/Packager.php b/app/Fluidbook/Packager/Packager.php index d83961ac1..b4e48ed37 100644 --- a/app/Fluidbook/Packager/Packager.php +++ b/app/Fluidbook/Packager/Packager.php @@ -25,7 +25,7 @@ class Packager extends \App\Jobs\Base public $book; /** @var FluidbookTheme */ protected $theme; - protected $scormVariant = false; + protected $variant = 'online'; protected $book_id; protected $themeRoot; protected $zip; @@ -129,7 +129,6 @@ class Packager extends \App\Jobs\Base $this->vdir = $vdir; $this->dir = Files::mkdir($this->packager_path('/' . $book_id)); - $forceCompile = false; if (count($options)) { $options['forceCompileOnDownload'] = true; @@ -188,7 +187,7 @@ class Packager extends \App\Jobs\Base */ protected function compile($forceCompile = false) { - $compiler = new Compiler($this->book, $this->scormVariant); + $compiler = new Compiler($this->book, $this->variant); $compiler->handle(); } @@ -323,7 +322,7 @@ class Packager extends \App\Jobs\Base $dest = $this->vdir; } - $compiler = new Compiler($book, $this->scormVariant, false, "latest", null, false, false, false, null, $hybrid); + $compiler = new Compiler($book, $this->variant, false, "latest", null, false, false, false, null, $hybrid); $compiler->handle(); $rsync = new CommandLine\Rsync(rtrim($compiler->getFinalPath(), '/'), $dest, true); diff --git a/app/Fluidbook/Packager/Scorm.php b/app/Fluidbook/Packager/Scorm.php index c7f4c0d14..108e0ec77 100644 --- a/app/Fluidbook/Packager/Scorm.php +++ b/app/Fluidbook/Packager/Scorm.php @@ -3,8 +3,7 @@ namespace App\Fluidbook\Packager; class Scorm extends Online { - protected $scormVariant = true; - + protected $variant = 'scorm'; public $type = 'scorm'; protected function preparePackage()