From: soufiane <soufiane@cubedesigners.com>
Date: Wed, 22 May 2024 10:44:42 +0000 (+0200)
Subject: wip #6927
X-Git-Url: http://git.cubedesigners.com/?a=commitdiff_plain;h=665197656b92678800ae65b46cca722c897af775;p=fluidbook-toolbox-quiz.git

wip #6927
---

diff --git a/js/quiz.accessibility.js b/js/quiz.accessibility.js
index 22c6899..fd65b69 100644
--- a/js/quiz.accessibility.js
+++ b/js/quiz.accessibility.js
@@ -26,10 +26,10 @@ QuizAccessibility.prototype = {
                 if (key === 'ENTER') {
                     let el = $(':focus').find('[aria-keyshortcuts]')
                     if(!el) {
-                        $('input:focus').click()
+                        $(':focus').click(function (e){ return false; })
                     }
                     if ($this.quiz.utils.isEnabled(el)) {
-                        el.get(0).click();
+                        el.get(0).click((e) => { return false; });
                         return true;
                     }
                 }
diff --git a/views/components/modal_more_info.blade.php b/views/components/modal_more_info.blade.php
index 5a752f1..ffa20dd 100644
--- a/views/components/modal_more_info.blade.php
+++ b/views/components/modal_more_info.blade.php
@@ -1,7 +1,7 @@
 <div class="explaination">
     <div class="explaination-wrapper">
         <p class="explaination-text"></p>
-        <a class="close-explaination" href="javascript:void(0)">
+        <a class="close-explaination" href="#">
             <span data-icon="wrong"></span>
         </a>
     </div>
diff --git a/views/footer.blade.php b/views/footer.blade.php
index 53afb27..00ac58e 100644
--- a/views/footer.blade.php
+++ b/views/footer.blade.php
@@ -1,20 +1,20 @@
 <footer class="footer-question footer">
     @isset($reset)
-        <a class="btn secondary reset" aria-keyshortcuts="R" href="javascript:void(0)">
+        <a class="btn secondary reset" aria-keyshortcuts="R" href="#">
             <span class="text">{{$__('Reset')}}</span>
             <span class="access">R</span>
         </a>
     @endisset
 
     @if(isset($info) && trim($info))
-        <a class="btn secondary none moreinfo" aria-keyshortcuts="M" href="javascript:void(0)">
+        <a class="btn secondary none moreinfo" aria-keyshortcuts="M" href="#">
             <span class="text">{{$__('More infos')}}</span>
             <span class="access infos">M</span>
         </a>
     @endif
 
     <a class="btn primary {{ isset($matchMaking) ? "confirmMatch" : "action validate" }} {{ $countdown ? ' countdown' : ''  }}"
-       aria-keyshortcuts="Space" href="javascript:void(0)">
+       aria-keyshortcuts="Space" href="#">
         <span class="text">
             @if(isset($matchMaking))
                 {{ $__('Confirm the match') }}
@@ -31,7 +31,7 @@
     </a>
 
     @if($data['instantReview'])
-        <a class="btn primary action none continue" aria-keyshortcuts="Space" href="javascript:void(0)">
+        <a class="btn primary action none continue" aria-keyshortcuts="Space" href="#">
             <span class="text">{{$__('Continue')}}</span>
             <span class="access space">{{$__('space')}}</span>
         </a>
diff --git a/views/screens/arrow.blade.php b/views/screens/arrow.blade.php
index 5947324..71f5938 100644
--- a/views/screens/arrow.blade.php
+++ b/views/screens/arrow.blade.php
@@ -7,7 +7,7 @@
         $key='ARROWRIGHT';
     }
 @endphp
-<a href="javascript:void(0)">
+<a href="#">
     <div class="controls {{$side}} {{$action}}" aria-keyshortcuts="{{$key}}">
         <p>{{$text}}</p>
         <div class="access">
diff --git a/views/screens/intro.blade.php b/views/screens/intro.blade.php
index 6477ee6..72bedf8 100644
--- a/views/screens/intro.blade.php
+++ b/views/screens/intro.blade.php
@@ -25,7 +25,7 @@
         <div class="markdown only-mobile">{!! $markdownToHTML($data->intro_text_mobile?:$data->intro_text) !!}</div>
     </div>
     <footer class="footer">
-        <a id="start" aria-keyshortcuts="Space" class="btn primary" href="javascript:void(0)">
+        <a id="start" aria-keyshortcuts="Space" class="btn primary" href="#">
             {{$data->intro_button?:$__('Let\'s start')}}<span class="access space">{{$__('space')}}</span>
         </a>
     </footer>
diff --git a/views/screens/outro.blade.php b/views/screens/outro.blade.php
index 8f4fbe6..cf4601a 100644
--- a/views/screens/outro.blade.php
+++ b/views/screens/outro.blade.php
@@ -40,7 +40,7 @@
                     </div>
                     @if($data->restart_button)
                         <div class="restart-sentence-mobile">{{$__('Want to improve your score?')}}</div>
-                        <a class="btn secondary restart restart-mobile" href="javascript:void(0)">
+                        <a class="btn secondary restart restart-mobile" href="#">
                             <span data-icon="reset"></span>
                             {{$__('Restart')}}
                         </a>
@@ -53,7 +53,7 @@
                 @endif
                 <div class="score-controls">
                     @if($data->restart_button)
-                        <a class="btn secondary restart" aria-keyshortcuts="r" href="javascript:void(0)">
+                        <a class="btn secondary restart" aria-keyshortcuts="r" href="#">
                             <span class="text">{{$__('Restart')}}</span>
                             <span class="access">R</span>
                         </a>