From: Vincent Vanwaelscappel <vincent@cubedesigners.com>
Date: Tue, 9 Jun 2020 18:18:40 +0000 (+0200)
Subject: wait #3692 @2.5
X-Git-Url: http://git.cubedesigners.com/?a=commitdiff_plain;h=04a4952d6b78fffa317f0d8a4181dd652b759eb7;p=fluidbook-html5.git

wait #3692 @2.5
---

diff --git a/js/libs/fluidbook/fluidbook.help.js b/js/libs/fluidbook/fluidbook.help.js
index 0ad58b6b..33089659 100644
--- a/js/libs/fluidbook/fluidbook.help.js
+++ b/js/libs/fluidbook/fluidbook.help.js
@@ -411,7 +411,7 @@ FluidbookHelp.prototype = {
     bookmarkLabel: function () {
 
         if (!this.fluidbook.bookmarks.enabled) {
-            return;
+            return '';
         }
         // The bookmark help element is a bit complex because it must be placed in a section of the help overlay that is
         // not already used by the icon labels. Since the menu can be either on the left or right, this needs to be taken
@@ -451,8 +451,10 @@ FluidbookHelp.prototype = {
         html += $('<div class="bookmark-help-label">' + this.fluidbook.l10n.__('add / remove bookmark') + '</div>')[0].outerHTML;
         var wrapper = $('<div class="bookmark-help">' + html + '</div>')[0].outerHTML
 
+        if(wrapper===undefined || wrapper==='undefined'){
+            return '';
+        }
         return wrapper;
     }
 }
-;
 
diff --git a/style/fluidbook.less b/style/fluidbook.less
index e17748e8..9bfcc9f6 100644
--- a/style/fluidbook.less
+++ b/style/fluidbook.less
@@ -1806,7 +1806,7 @@ form input[type="text"], form input[type="email"] {
     padding: 10px 10px 25px 10px;
     margin: 0 5px 15px;
     position: relative;
-    width: 200px;
+    width: unit(@thumb-width*2, px);
     cursor: pointer;
     text-align: center;
     box-sizing: content-box;
@@ -1814,7 +1814,7 @@ form input[type="text"], form input[type="email"] {
     vertical-align: top;
 
     &.singlemode {
-      width: 100px;
+      width: @thumb-width;
     }
   }
 
@@ -1825,7 +1825,7 @@ form input[type="text"], form input[type="email"] {
     padding: 20px @padding 0;
 
     .doubleThumb {
-      width: 100px;
+      width: @thumb-width;
 
       .rtl & {
         position: relative;
@@ -1851,7 +1851,7 @@ form input[type="text"], form input[type="email"] {
   &.simple {
 
     .overlay {
-      width: 100px;
+      width: @thumb-width;
     }
 
     &.left {
@@ -1911,7 +1911,6 @@ form input[type="text"], form input[type="email"] {
 }
 
 .thumb {
-  @thumb-width: 100px;
   position: absolute;
   width: @thumb-width;
   height: @thumb-height;
@@ -1985,15 +1984,15 @@ form input[type="text"], form input[type="email"] {
   }
 
   &.simple {
-    width: 100px;
+    width: @thumb-width;
 
     &.right {
-      margin-left: 100px;
+      margin-left: @thumb-width;
     }
   }
 
   &.left {
-    margin-right: 100px;
+    margin-right: @thumb-width;
   }
 
   @extrashadowheight: min(22, @thumb-height*0.2);
@@ -2008,7 +2007,7 @@ form input[type="text"], form input[type="email"] {
     opacity: 0.65;
     top: -5px;
     left: -5px;
-    width: 111px;
+    width: unit(@thumb-width+11, px);
     height: @shade-height;
     z-index: 0;
   }
diff --git a/style/mobilefirst.less b/style/mobilefirst.less
index 9957ccf4..d7b7fdb5 100644
--- a/style/mobilefirst.less
+++ b/style/mobilefirst.less
@@ -162,7 +162,7 @@
 
     .doubleThumb {
       &.simple {
-        width: 100px;
+        width: @thumb-width;
       }
     }
 
diff --git a/style/print.less b/style/print.less
index 652b1a2f..e4c141f8 100644
--- a/style/print.less
+++ b/style/print.less
@@ -39,12 +39,12 @@
   }
 
   .thumb.right {
-    left: 100px; // Override default so there's no gap between pages
+    left: @thumb-width; // Override default so there's no gap between pages
   }
 
   // Blank pages
   .thumb.blank {
-    width: 100px;
+    width: @thumb-width;
     height: @thumb-height;
 
     // We need to mask the shadow so the :after layer can sit on top with
@@ -74,7 +74,7 @@
   .bookmark-thumbnails {
     .thumb {
       &:before {
-        width: 113px; // Controls drop shadow on right side of thumbnail
+        width: unit(@thumb-width+13, px); // Controls drop shadow on right side of thumbnail
       }
 
       &:nth-child(1) {
@@ -87,22 +87,22 @@
       }
 
       &:nth-child(2) {
-        left: 50px;
+        left: unit(@thumb-width/2, px);
         z-index: 2;
 
         .rtl & {
-          right: 50px;
+          right: unit(@thumb-width/2, px);
           left: auto;
 
         }
       }
 
       &:nth-child(3) {
-        left: 100px;
+        left: @thumb-width;
         z-index: 1;
 
         .rtl & {
-          right: 100px;
+          right: @thumb-width;
           left: auto;
           z-index: 3;
         }
@@ -211,7 +211,7 @@
 
       &[for="allPages"] {
         .doubleThumb {
-          left: 100px;
+          left: @thumb-width;
         }
       }
     }
diff --git a/style/slider.less b/style/slider.less
index f3569c89..a7ebd88a 100644
--- a/style/slider.less
+++ b/style/slider.less
@@ -75,14 +75,14 @@
     background-color: @slider-thumb-background;
     padding: 25px;
     display: none;
-    width: 250px;
+    width: unit(@thumb-width*2+50, px);
     height: @sliderthumb-height;
 
     &.single {
-      width: 150px;
+      width: unit(@thumb-width+50, px);
 
       &:after {
-        left: 59px;
+        left: unit(@thumb-width/2+9, px);
       }
 
       .doubleThumb .thumb.right {
@@ -96,7 +96,7 @@
       content: "";
       position: absolute;
       bottom: -16px;
-      left: 109px;
+      left: unit(@thumb-width+9, px);
       width: 0;
       height: 0;
       border-left: 16px solid transparent;
@@ -110,7 +110,7 @@
 
       > .thumb {
         &.right {
-          left: 100px;
+          left: @thumb-width;
         }
 
         a.bookmark {