From: Stephen Cameron <stephen@cubedesigners.com>
Date: Fri, 20 Oct 2017 14:56:27 +0000 (+0200)
Subject: Open "extra" link in new tab. Fix spacing bug in burger menu. WIP #1762 @0.25
X-Git-Url: http://git.cubedesigners.com/?a=commitdiff_plain;h=0430afb92fec00523a56a6189f4f5342299cb463;p=fluidbook-html5.git

Open "extra" link in new tab. Fix spacing bug in burger menu. WIP #1762 @0.25
---

diff --git a/js/libs/fluidbook/fluidbook.nav.js b/js/libs/fluidbook/fluidbook.nav.js
index ad998d9c..0f1074bd 100644
--- a/js/libs/fluidbook/fluidbook.nav.js
+++ b/js/libs/fluidbook/fluidbook.nav.js
@@ -443,11 +443,11 @@ FluidbookNav.prototype = {
 
                 if (navType == 'horizontalNav') {
                     navExtraImage = this.fluidbook.datas.navExtraImage;
-                    link = '<a id="' + elementID + '" data-tooltip="' + this.fluidbook.datas.navExtraTooltip + '" href="' + this.fluidbook.datas.navExtraLink + '"><img class="nav-icon" src="data/images/' + navExtraImage + '"></a>';
+                    link = '<a id="' + elementID + '" data-tooltip="' + this.fluidbook.datas.navExtraTooltip + '" href="' + this.fluidbook.datas.navExtraLink + '" target="_blank" rel="noopener noreferrer"><img class="nav-icon" src="data/images/' + navExtraImage + '"></a>';
 
                 } else if (navType == 'menu') {
                     navExtraImage = this.fluidbook.datas.navExtraImageMobile || this.fluidbook.datas.navExtraImage; // Fallback to desktop image
-                    link = '<a id="' + elementID + '" href="' + this.fluidbook.datas.navExtraLink + '"><img class="nav-icon" src="data/images/' + navExtraImage + '"><span class="menu-item-title">' + this.fluidbook.datas.navExtraTooltip + '</span></a>';
+                    link = '<a id="' + elementID + '" href="' + this.fluidbook.datas.navExtraLink + '" target="_blank" rel="noopener noreferrer"><img class="nav-icon" src="data/images/' + navExtraImage + '"> <span class="menu-item-title">' + this.fluidbook.datas.navExtraTooltip + '</span></a>';
                 }
 
                 $nav.find('ul').append('<li>' + link + '</li>');