]> _ Git - fluidbook-html5.git/commitdiff
Open "extra" link in new tab. Fix spacing bug in burger menu. WIP #1762 @0.25
authorStephen Cameron <stephen@cubedesigners.com>
Fri, 20 Oct 2017 14:56:27 +0000 (16:56 +0200)
committerStephen Cameron <stephen@cubedesigners.com>
Fri, 20 Oct 2017 14:56:27 +0000 (16:56 +0200)
js/libs/fluidbook/fluidbook.nav.js

index ad998d9c6697ed5e9c6974277151110cc5db4218..0f1074bdc09c920e98f8fac532e6ba2a69e5c8c0 100644 (file)
@@ -443,11 +443,11 @@ FluidbookNav.prototype = {
 
                 if (navType == 'horizontalNav') {
                     navExtraImage = this.fluidbook.datas.navExtraImage;
-                    link = '<a id="' + elementID + '" data-tooltip="' + this.fluidbook.datas.navExtraTooltip + '" href="' + this.fluidbook.datas.navExtraLink + '"><img class="nav-icon" src="data/images/' + navExtraImage + '"></a>';
+                    link = '<a id="' + elementID + '" data-tooltip="' + this.fluidbook.datas.navExtraTooltip + '" href="' + this.fluidbook.datas.navExtraLink + '" target="_blank" rel="noopener noreferrer"><img class="nav-icon" src="data/images/' + navExtraImage + '"></a>';
 
                 } else if (navType == 'menu') {
                     navExtraImage = this.fluidbook.datas.navExtraImageMobile || this.fluidbook.datas.navExtraImage; // Fallback to desktop image
-                    link = '<a id="' + elementID + '" href="' + this.fluidbook.datas.navExtraLink + '"><img class="nav-icon" src="data/images/' + navExtraImage + '"><span class="menu-item-title">' + this.fluidbook.datas.navExtraTooltip + '</span></a>';
+                    link = '<a id="' + elementID + '" href="' + this.fluidbook.datas.navExtraLink + '" target="_blank" rel="noopener noreferrer"><img class="nav-icon" src="data/images/' + navExtraImage + '"> <span class="menu-item-title">' + this.fluidbook.datas.navExtraTooltip + '</span></a>';
                 }
 
                 $nav.find('ul').append('<li>' + link + '</li>');